Ladsgroup added a comment.
Yes, my comment was a very local/band-aid type of solution. Mostly to avoid changing too much (which has risk of breaking things) but I totally agree with you. This class at its current shape is violating ISP and splitting it makes lots of sense (not to mention we should avoid setters in general to make classes immutable which would make them more predictable) TASK DETAIL https://phabricator.wikimedia.org/T257439 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Aklapper, WMDE-leszek, ItamarWMDE, Ladsgroup, Lucas_Werkmeister_WMDE, Tarrow, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
