dcausse added a comment.
In T256875#6364443 <https://phabricator.wikimedia.org/T256875#6364443>, @Mstyles wrote: > What do we want to do if we get a PageDelete event for the same item multiple times? Right now we're not tracking deletes, so I'm assuming multiple deletes for the same item probably can't do that much harm. I still don't know the best way to track this, multiple deletes won't harm much indeed but what we should avoid is treating a late RevCreateEvent as a new item to import while in reality it's deleted. Ideally we want to clear the state when we see a deletion but this might not allow us to track this kind of situation. Another possibility is to tell the state that we have seen a DeletePage for revision X by storing -X in the state (basically using the sign as flag to indicate previous deletion). I think this will have to be decided while implementing multiple unit tests simulating the various scenario we might see. TASK DETAIL https://phabricator.wikimedia.org/T256875 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mstyles, dcausse Cc: Aklapper, dcausse, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
