Ladsgroup added a comment.
In T258822#6373759 <https://phabricator.wikimedia.org/T258822#6373759>, @Lucas_Werkmeister_WMDE wrote: > In T258822#6373587 <https://phabricator.wikimedia.org/T258822#6373587>, @Reedy wrote: > >> In T258822#6373399 <https://phabricator.wikimedia.org/T258822#6373399>, @ItamarWMDE wrote: >> >>> Concluding from the discussion on the patch. It appears that there isn't an elegant way to achieve this. After a discussion with @Lucas_Werkmeister_WMDE we propose to mark this task as declined. However, we keep this open for now, in case someone else has an elegant way to resolve it. >> >> Why would you decline a bug that is valid? > > Because Declined is not the same as Invalid? I’m not saying the bug isn’t valid, but we may still decline to resolve it. > >> I could understand marking it stalled, dependant on another bug being filed and fixed (ie something to support Wikibase's non standard file heirarchy), but it's definitely not invalid. > > How, then, would you support Wikibase’s file hierarchy in MediaWiki core? > > I can think of two ways: > > 1. Hard-code in MediaWiki core where Wikibase’s extension JSON files are, so that the installer can load them correctly. > > 2. Extend the extension JSON syntax, and require extensions depending on Wikibase to write something like this: > > "requires": { > "extensions": { > "WikibaseClient": { > "baseName": "Wikibase", > "jsonName": "extension-client.json", > "version": "*" > } > } > }, > > Both seem so terrible to me that I’d rather decline this task than implement either of them. If you have a better idea, let us know, that’s why we left this task open for a bit. But my impression is that this task is not doable – neither core nor other extensions should have special knowledge of Wikibase paths, but those paths have to be //somewhere// if the installer is supposed to be able to locate Wikibase automatically. Actually I think there's a rather easier path to go to and it doesn't involve splitting Wikibase git repo either. `Installer.php` currently loads the files and check for their existence. The whole logic seems wrong to me, it should load extensions from the extension registry or check if they are in the queue and check it only based on name. If it can't find the extension in extension registry, then It should fall back to loading it directly from file and its current logic. In my personal opinion what Wikibase is doing is not "non-standard", it's just different (Wikibase is unique in so many ways, this the least of the differences) but I think the logic of loading extensions should be hidden and abstracted to ExtensionRegistry class which its whole point is to abstract this away. > How does Wikibase even get loaded properly for CI with the non standard paths? Does -with-extensions do something more recursively? Or does it not get loaded at all? It looks for Wikibase.php, that file loads extension json files. TASK DETAIL https://phabricator.wikimedia.org/T258822 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, ItamarWMDE, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, cmadeo, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
