Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Technical-Debt,
wdwb-tech-focus, DataValues, PHP 7.4 support.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
As a developer, I want to be able to work on the data-values libraries using
the newest PHP version.
**Problem:**
Our data-values libraries still use PHPUnit 4. WikibaseRepo has very clear
words for this:
name=repo/tests/phpunit/includes/Parsers/PHPUnit4CompatTrait.php
/**
* Awful hack: several tests extend DataValues test classes. DataValues
works on PHPUnit4 only, hence
* it uses setExpectedException (amongst other things). But Wikibase
requires PHP 7.2+ and PHPUnit6+,
* where setExpectedException doesn't exist anymore. This was resolved by
using the PHPUnit4And6Compat
* trait provided by core, but that's deprecated as of 1.34.
*
* @todo Get rid of this trait as soon as DataValues moves away from
withered PHPUnit.
*/
trait PHPUnit4CompatTrait {
PHPUnit 4 doesn’t even work under PHP 7.4 anymore, so it’s not possible to
test these libraries under the latest released PHP version.
**Example:**
wmde/Time#149 <https://github.com/wmde/Time/pull/149> is an attempt to pull
data-values/time into the present day but it’s kicking and screaming and
generally being annoying about it.
**Screenshots/mockups:**
**BDD**
GIVEN
AND
WHEN
AND
THEN
AND
**Acceptance criteria:**
- The DataValues libraries use recent versions of PHPUnit, as well as of
Wikibase CodeSniffer and other libraries.
**Open questions:**
- We could use this opportunity to move (some of) these libraries into the
Wikibase monorepo, as proposed in ADR #14
<https://doc.wikimedia.org/Wikibase/master/php/adr_0014.html>. Do we want to do
that?
TASK DETAIL
https://phabricator.wikimedia.org/T260915
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, DannyS712,
Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer,
_jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000,
Nikerabbit, MaxSem, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
