EBernhardson added a comment.
This bit of code includes the comment
// FIXME: this is a hack, we need to return Status upstream instead
The value that is being logged here was intended for end users, it provides
an i18n message to tell the user what went wrong. In this case there was a
failure communicating with the backend service. Failure rates are already
tracked and alerted on, the log message here is unactionable.
Tempted to simply drop the code that logs these. It was trying to make sure
it didn't simply ignore the error, but amounts to spamming up logs with
messages for the end user.
TASK DETAIL
https://phabricator.wikimedia.org/T260276
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: EBernhardson
Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz,
darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden,
EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs,
aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair,
jeremyb
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
