Jakob_WMDE removed guergana.tzatchkova as the assignee of this task. Jakob_WMDE added a subscriber: guergana.tzatchkova. Jakob_WMDE reopened this task as "Open". Jakob_WMDE moved this task from Done to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Jakob_WMDE added a comment.
Reopening this ticket, as it seems incomplete and not working as intended. 1. The termbox submodule pin in Wikibase wasn't updated. Production is now running an old termbox version from March that lists Vue as a dependency, but doesn't actually have it externalized. 2. Even with the pin updated, the latest version doesn't seem to work in integration with Wikibase. Unless I'm doing something wrong, it seems that for termbox it isn't as easy as telling the build config to externalize the library. Termbox isn't yet following the init/app split as bridge or tainted references, so it may not know that it needs to `require` (commonjs) Vue. I stumbled across this because I was trying to improve the termbox browser test after running into issues on a completely unrelated change <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/refs/changes/47/628047/4/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php#174>. Current termbox master does not work in integration with Wikibase. As far as I know there aren't any user-facing changes in the making for termbox, but a broken master branch is not good. This needs to be looked into. TASK DETAIL https://phabricator.wikimedia.org/T228528 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: guergana.tzatchkova, Michael, WMDE-leszek, Aklapper, Jakob_WMDE, Tarrow, Pablo-WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
