Marostegui added a comment.

  So, I have captured a lots of queries involving `wb_changes` and I haven't 
found any single query that has a crazy query plan as a result of deleting 
`wb_changes_change_type wb_changes_change_object_id wb_changes_change_user_id`.
  Also, I have checked if those reported unused indexes are consistent across 
all the hosts and they seem to be:
  
    db2100.codfw.wmnet:3318
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2094.codfw.wmnet:3318
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_time
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2091.codfw.wmnet:3306
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2086.codfw.wmnet:3318
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2085.codfw.wmnet:3318
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2084.codfw.wmnet:3306
    db2083.codfw.wmnet:3306
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2082.codfw.wmnet:3306
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2081.codfw.wmnet:3306
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2080.codfw.wmnet:3306
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
    wikidatawiki        wb_changes      wb_changes_change_revision_id
    db2079.codfw.wmnet:3306
    object_schema       object_name     index_name
    wikidatawiki        wb_changes      wb_changes_change_type
    wikidatawiki        wb_changes      wb_changes_change_object_id
    wikidatawiki        wb_changes      wb_changes_change_user_id
  
  Some of them do report `wb_changes_change_revision_id`, some others don't. 
But as Amir said at T262856#6486318 
<https://phabricator.wikimedia.org/T262856#6486318>, it might be used, so let's 
leave it there.
  @Ladsgroup I think we can probably go ahead and create a proper schema change 
ticket and delete: `wb_changes_change_type wb_changes_change_type 
wb_changes_change_user_id`.
  It is not a huge table, so if we see something very strange once in 
production on more hosts, we can probably alter it quickly.
  
    -rw-rw---- 1 mysql mysql 2.0G Sep 24 07:28 wb_changes.ibd
  
  Anything else left on this task then?

TASK DETAIL
  https://phabricator.wikimedia.org/T262856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Marostegui
Cc: Kormat, Marostegui, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, 
LSobanski, Akuckartz, Iflorez, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Minhnv-2809, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to