thcipriani added a comment.
In T252124#6494323 <https://phabricator.wikimedia.org/T252124#6494323>, @Zbyszko wrote: > @thcipriani I have the change in puppet (https://gerrit.wikimedia.org/r/630081). What else would I need to do to guarantee that generated lists in /etc/dsh/groups are picked up? I rather leave everything else configured as it is right now (https://github.com/wikimedia/wikidata-query-deploy/blob/master/scap/scap.cfg) In order to have scap use that file, you should set `dsh_targets: wdqs` and ensure `default` is in `server_groups`. server_groups: default dsh_targets: wdqs WDQS currently has 6 different server groups <https://github.com/wikimedia/wikidata-query-deploy/blob/b7e2d0b5741ca39b84c34b1b267f106c23c38979/scap/scap.cfg#L2>: `canary,codfw,codfw_internal,eqiad,eqiad_internal,test` The dsh_groups and server_groups serve a few different purposes: 1. list the hosts to target 2. group hosts to deploy simultaneously 3. define the order of rollout to each server It looks like you have 17 hosts in 6 groups which is a lot of groups. The best path forward depends on how you want to deploy. Does it matter that `codfw` goes out before `codfw_internal`? If not, you could get rid of a lot of these groups, keep the canary group (if it's important) and change `server_groups` to something like: `canary, default` and remove all the other `*_dsh_targets` from your scap.cfg and the `scap` directory. This would roll out to the canary hosts, give you a chance to check them and roll back if needed, and then will deploy to the remainder of hosts as one big group. This may or may not be what you want to do. If your goal is to *keep* all these groups and just ensure you're not missing any servers you could always change `server_groups` to `server_groups: canary, codfw, codfw_internal, eqiad, eqiad_internal, test, default` which would keep the setup you have now, and use the puppet generated dsh group as a final group that would "catch" any hosts that you miss deploying to. Let me know your target and I can help with the config to achieve it. TASK DETAIL https://phabricator.wikimedia.org/T252124 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Zbyszko, thcipriani Cc: thcipriani, Aklapper, RKemper, Gehel, lmata, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, Legado_Shulgin, CucyNoiD, Nandana, Namenlos314, Gaboe420, Giuliamocci, Davinaclare77, Qtn1293, Cpaulf30, Techguru.pc, Lahi, Gq86, Af420, Bsandipan, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Rxy, Jay8g, Krenair, fgiunchedi, jeremyb
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
