Lucas_Werkmeister_WMDE added a comment.
But I don’t think this is a problem with just `PrefetchingItemTermLookup`…
from a quick `git grep`, roughly two thirds of `$this->incrementForQuery()`
calls aren’t directly related to a database query, I’d say. If I’m not
mistaken, this new `StatsdMonitoring` trait (which creates the measurements for
`wikibase.query_contexts.{repo,client},term_store,{query_type}`) was introduced
by replacing existing calls to statsd, but those existing calls had never been
written with the intention to correspond 1:1 to database queries, so now we’re
getting skewed data, where the same query might be logged multiple times at
different levels.
TASK DETAIL
https://phabricator.wikimedia.org/T262923
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Rosalie_WMDE, toan, Lucas_Werkmeister_WMDE, Aklapper,
Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, jijiki,
Klaas_Z4us_V, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer,
elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude,
Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
