Tarrow added a comment.
**Reasons to NOT add a list of valid services to the spec** - Adding an allow list to the spec is challenging without having 2 sources of truth. Because it is currently a static `schemas.json` file we'd need to keep this in sync with `ExternalServices.php` which would probably require some clever additional test or be fragile to developers making mistakes. - We would need to always update the spec - Users referring to a historic spec might have differing expectations - It might suggest to toolbuilders to write tools that are less extensible (e.g. they might try to hardcode these values) **Reasons to add the list of services to the spec** - It makes our end-2-end test feel more solid - It helps set the expectations of tools builders **Thoughts considered but immaterial** - It probably makes no difference for a Wikibase admin. They will be looking in the configuration docs not the spec TASK DETAIL https://phabricator.wikimedia.org/T265118 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Aklapper, Tarrow, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
