Lucas_Werkmeister_WMDE added a comment.
Task inspection notes: - The “no longer cause fatal errors” and “no data is returned” ACs are already fulfilled since 2015, thanks to T108252 <https://phabricator.wikimedia.org/T108252> (created and resolved only a few months after this task was created). - We interpret “no data is returned” / “blank data” to mean that returning `nil` to Lua is acceptable, and we don’t need to synthesize a blank item like `{"type": "item", "labels": {}}`. - So the only think left to do is to remove the logging (or possibly lower its level to notice/info; in this case, we can also inject a logger instead of using the global `wfLogWarning()` function). TASK DETAIL https://phabricator.wikimedia.org/T93273 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, BPirkle, gerritbot, PokestarFan, Krinkle, mmodell, Addshore, Bene, hoo, JanZerebecki, thiemowmde, Lydia_Pintscher, aude, Aklapper, CBogen, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
