thiemowmde added a comment.

  My suggestion for this migration would be to copy-paste the entire file 
https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to 
every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify 
it, e.g. remove exclusions you don't want to exclude any more, as well as 
remove additions you don't care about. I suggest to keep the comments, as they 
help other developers to understand that some exclusions are very intentional, 
and the Wikidata team doesn't want anybody to re-enable them (if this is still 
the case). Note that excluding a sniff is not a bad thing, and doesn't mean the 
code is bad. At this point we have sooo many sniffs, and many of them are about 
teeny tiny details nobody would really argue about. Feel free to diverge from 
the MediaWiki rule set a bit if it makes your team feel more comfortable.

TASK DETAIL
  https://phabricator.wikimedia.org/T266823

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Jay8g, Legoktm
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to