ItamarWMDE added a comment.

  PR up for review at #262 <https://github.com/wmde/wikit/pull/262>.
  
  **Task Learnings**
  
  Github Composite actions 
<https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/creating-a-composite-run-steps-action>
 will allow reusing 3rd party actions soon. See:
  
  - https://github.com/actions/runner/issues/438
  - https://github.com/actions/runner/issues/646
  
  This can DRY up the workflow files quite considerably, and make common setup 
reusable (TASK TBD)
  
  In addition these steps thake the longest to complete and might be 
potentially improved in the future
  
  - Test and Deploy/deploy -> Build Storybook (~2.5 mins), can be sped up by 
caching story book assets under their own key (TASK TBD)
  - Test and Deploy/test -> Test (~44 seconds), not too bad currently but will 
grow considerably once more components are added, can be skipped by adding a 
"logical" filter group for unit test (TASK TBD)

TASK DETAIL
  https://phabricator.wikimedia.org/T266460

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to