Michael added a comment.
In T267730#6620815 <https://phabricator.wikimedia.org/T267730#6620815>, @Ladsgroup wrote: > In T267730#6620779 <https://phabricator.wikimedia.org/T267730#6620779>, @Michael wrote: > >> Thanks for the PR! >> >> Could you explain a bit about why you chose `vue-banana-i18n` over `vue/i18n.js`? > > Mostly because 1- it's not librarified (only works inside mw or we should copy paste everything) and 2- it wouldn't work outside of context of mediawiki (look that it depends on "mw" global object) Ah don't get me wrong, I totally accept that `vue-banana-i18n` is the right choice for us, if you say that it is. But I'm not familiar with those two libraries (we used neither in Bridge (nor in Termbox or TaintedRef as far as I can tell)) and so it was important for me that it is actually stated in this investigation ticket why we are going for one over the other. Both for me and for other people that might not be familiar with those libraries and that might look at this ticket in the future. :) I'll have another look at the PR TASK DETAIL https://phabricator.wikimedia.org/T267730 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Michael Cc: Ladsgroup, Aklapper, Michael, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
