Ladsgroup added a comment.
There's an a11y issue with the current design, the a11y tests is now failing (https://github.com/wmde/query-builder/pull/33/checks?check_run_id=1432756100): FAIL tests/unit/components/QueryBuilder.spec.ts ● QueryBuilder.vue › should not have obvious accessibility issues expect(received).toHaveNoViolations(expected) Expected the HTML found at $('select') to have no violations: <select class="querybuilder__dropdown"> Received: "Form elements must have labels (label)" Fix any of the following: aria-label attribute does not exist or is empty aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty Form element does not have an implicit (wrapped) <label> Form element does not have an explicit <label> Element has no title attribute or the title attribute is empty Element's default semantics were not overridden with role="none" Element's default semantics were not overridden with role="presentation" You can find more information on this issue here: https://dequeuniversity.com/rules/axe/4.0/label?application=axeAPI The drop down needs to have a label. TASK DETAIL https://phabricator.wikimedia.org/T265245 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Lydia_Pintscher, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
