Lucas_Werkmeister_WMDE added a comment.
Task inspection notes: The RemoteRenderer in PHP is TermboxRemoteRenderer.php <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/f0a9d0fcff3bd21dc5f3768cb501577876ced4cd/view/src/Termbox/Renderer/TermboxRemoteRenderer.php>; it logs “case A” (timeout) in line 61 <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/f0a9d0fcff3bd21dc5f3768cb501577876ced4cd/view/src/Termbox/Renderer/TermboxRemoteRenderer.php#61> and “case B” (SSR service got error from MediaWiki) in line 63 <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/f0a9d0fcff3bd21dc5f3768cb501577876ced4cd/view/src/Termbox/Renderer/TermboxRemoteRenderer.php#63>. We also agreed that all kinds of errors in the SSR service should already be logged – the termbox SSR service can instruct the service runner <https://github.com/wikimedia/service-runner> to log an error, or the service runner will itself log an error if it can’t even start the service properly – but in any case, in PHP land we can assume that an error we get was already logged, and we can safely downgrade to “notice” all the time. TASK DETAIL https://phabricator.wikimedia.org/T255436 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, Addshore, Aklapper, Tarrow, Akuckartz, darthmon_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
