Addshore added a comment.
Looking at usages of that config variables now: - Old usage from the entity cache that we previously removed (now just uses CACHE_NONE) https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/client/includes/Store/Sql/DirectSqlStore.php#383 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/repo/includes/Store/Sql/SqlStore.php#388 - Usage in the property info caches https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/client/includes/Store/Sql/DirectSqlStore.php#440 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/repo/includes/Store/Sql/SqlStore.php#452 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/repo/includes/Store/Sql/SqlStore.php#494 - Usage in the termfallback cache https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/client/includes/WikibaseClient.php#1271 https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/repo/includes/WikibaseRepo.php#2321 - PropertyLabelResolver https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/client/includes/WikibaseClient.php#1330 - CachingEntityRevisionLookup https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/b2705a5cf9bc4daeae15466948f1dfce14305878/repo/includes/Store/Sql/SqlStore.php#417 We would probably benefit from: - Continuing to remove this old entity cache that we pass CACHE_NONE into now - Evaluating if we need PropertyLabelResolver in its current form, or if it should change somewhat now? - Split the caches to have their own configurable ttls? - Evaluate the final CachingEntityRevisionLookup and see if this even needs the cache any more TASK DETAIL https://phabricator.wikimedia.org/T254536 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Addshore Cc: Lucas_Werkmeister_WMDE, CDanis, WMDE-leszek, Addshore, Ladsgroup, Joe, Krinkle, Aklapper, Hazizibinmahdi, Akuckartz, Iflorez, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
