Lucas_Werkmeister_WMDE added a comment.
In T269608#6677337 <https://phabricator.wikimedia.org/T269608#6677337>, @thcipriani wrote: > In T269608#6677098 <https://phabricator.wikimedia.org/T269608#6677098>, @Jdforrester-WMF wrote: > >> Also, do we know how this broke so badly and unexpectedly? Would be nice to avoid it recurring. > > I am confused about this as well and I don't know that anyone has found any clear root cause. That is, if the code changes between the merged and failing patches were not the cause of the failures, and CI infra didn't change: what caused this to start failing and if it's correct that these tests should have been failing what caused CI to not notice? No clue. I think the FlaggedRevs fix makes sense either way, but for `HtmlPageLinkRendererEndHookHandlerTest` we still need to find a proper solution. So far my only idea is to push WIP changes with more and more debug logging to Gerrit and see what happens in CI, because I still haven’t been able to reproduce this locally. (So far I uploaded a revert <https://gerrit.wikimedia.org/r/649643>, just to see if it still fails – it does – but without adding any logging yet. This could also be taken over by someone else on the Wikidata team.) TASK DETAIL https://phabricator.wikimedia.org/T269608 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: kostajh, Addshore, Nikerabbit, Jdforrester-WMF, thcipriani, hashar, Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
