Sarai-WMDE added a comment.
Do we want to implement the following TextInput behaviour as part of this task? These are specs we discussed in our catch up, but were only added to the main story (T270179 <https://phabricator.wikimedia.org/T270179>): - Displaying a placeholder (instead of NaN) when the input is deleted (see mocks) <https://www.figma.com/file/hZpaYX0xNNhK0L7kBvN6WK/Query-Builder?node-id=2788%3A4> - When running the query with an empty input field (but an active checkbox) the field is re-filled with the default value (100). - I'm not sure that the label has been visually hidden following the suggested strategy <https://github.com/wmde/query-builder/pull/129/files> (see notes <https://docs.google.com/document/d/1NkLNq2c-LXu9Vp7Or5TPlNFHY2zaxNLfssPQX3GFH2Q/edit?usp=sharing>) but I guess I probably missed out something TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Sarai-WMDE Cc: Sarai-WMDE, Michael, Lydia_Pintscher, Aklapper, guergana.tzatchkova, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
