Lucas_Werkmeister_WMDE added a subscriber: Lydia_Pintscher. Lucas_Werkmeister_WMDE added a comment.
In T97146#6722568 <https://phabricator.wikimedia.org/T97146#6722568>, @Jakob_WMDE wrote: > … when an undo is requested, first check whether the current revision has the same redirect status as the revision to be undone … There is also another situation that currently throws the same PatcherException. When undoing an edit that changed a redirect back into an ordinary entity, but that edit is also not the latest edit (i.e. there were more ordinary edits later), then the current revision has the same redirect status as the revision to be undone, but the undo still crashes. In other words, when the history looks like this: - … older revisions - revision A: entity is redirect - revision B: entity is no longer redirect - revision C: regular edit (e.g. add label) Undoing revisions B and C together works, but undoing revision B alone crashes. @Lydia_Pintscher what should happen in that case? Should we turn the entity back into a redirect, ignoring the other edits that were made since then (revision C)? Or should we report an edit conflict? TASK DETAIL https://phabricator.wikimedia.org/T97146 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, Mbch331, Rxy, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
