ItamarWMDE created this task.
ItamarWMDE added a project: Wikidata Design System.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Currently, it is possible for a `Button` component implementer to provide a 
combination of `variant` and `type` props which does not exist, such as 
`<Button variant="primary" type="neutral">`.
  
  Ideally, this should not be possible, and a warning should be logged out to 
developers who implement this component that way.
  
  **AC**:
  
  [ ] Using invalid combinations of the `variant` and `type` props on a 
`Button` results in a vue validation warning.
  
  **Hints:**
  
  - This can potentially be achieved by slightly modifying the current 
validation rules utilizing a combination map of variant → types such as:
  
    const combinationMap = {
        "normal": [ "neutral" ],
        "primary": [ "progressive", "destructive" ]
    }

TASK DETAIL
  https://phabricator.wikimedia.org/T272042

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4521/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to