Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: wdwb-tech-focus, MediaWiki-extensions-WikibaseRepository, Technical-Debt. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata.
TASK DESCRIPTION In WikibaseRepo, the `ActionTestCase` class is the base class for `EditEntityActionTest` (which tests `EditEntityAction` and `SubmitEntityAction`) and `ViewEntityActionTest` (which tests `ViewEntityAction`). The base class sets up a collection of test items, referred to by “handles” rather than item IDs, with several revisions; the test cases in `EditEntityActionTest`, and a handful of tests in `ViewEntityActionTest` as well, then use those test items. This means that `ActionTestCase` needs to be adjusted when new tests in `EditEntityActionTest` are needed, and the tests in `EditEntityActionTest` are incomprehensible without first looking at `ActionTestCase`’s `makeTestItemData()` and understanding how it works. It would be better to move the test data into the test classes that actually needs the data. This came up during the review of I17f3e9e887: Handle error when mixing redirects in undo <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/655726> (for T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits <https://phabricator.wikimedia.org/T97146>). TASK DETAIL https://phabricator.wikimedia.org/T272291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Addshore, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
