dcausse created this task.
dcausse added a project: Wikidata-Query-Service.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.
TASK DESCRIPTION
As a developper of the scala projects in the wdqs repo I want scalastyle to
checks the import order so that the imports order remains consistent.
There seem to be a check in our rule but it does not seem effective:
<check level="error" class="org.scalastyle.scalariform.ImportOrderChecker"
enabled="true">
<parameters>
<parameter name="groups">java,scala,other</parameter>
<parameter name="group.java">javax?\..*</parameter>
<parameter name="group.scala">scala\..*</parameter>
<parameter name="other">.*</parameter>
</parameters>
</check>
We also have some intelliJ config
<https://repo1.maven.org/maven2/org/wikimedia/discovery/discovery-maven-tool-configs/1.14/discovery-maven-tool-configs-1.14-intellij-config.jar>
that can be imported to assist the developper containing proper import orders
<https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/discovery/discovery-maven-tool-configs/+/refs/heads/master/src/editors/intellij/codestyles/scala_imports.xml>.
AC:
- import orders are checked during the build ran in our CI
- import orders are consistent with the config provided through
discovery-maven-tool-configs
TASK DETAIL
https://phabricator.wikimedia.org/T272994
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: dcausse
Cc: dcausse, Aklapper, MPhamWMF, CBogen, Akuckartz, Nandana, Namenlos314, Lahi,
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst,
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll,
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
