Lucas_Werkmeister_WMDE added subscribers: Mholloway, Ottomata. Lucas_Werkmeister_WMDE added a comment.
In T272998#6778032 <https://phabricator.wikimedia.org/T272998#6778032>, @Lucas_Werkmeister_WMDE wrote: >> I’m not sure why this only started failing now – which part of that chain changed recently – but I think the fix ought to be that `MockHttpTrait` passes a callback into the mocks which wraps `TestCase::fail()` but discards any arguments with which it was called. > > Wait, but that would still make the test fail, just differently… I’m confused now. Yeah, the test still fails in that empty change to test CI, just with a better error message – instead of a `TypeError` it’s now “method should not be called”. I can reproduce the error locally when loading the EventBus extension, and the error still remains if I revert MediaWiki core, Wikibase, and EventBus to ten commits earlier. (In the case of MediaWiki, even fifty commits.) But unlike in T269608 <https://phabricator.wikimedia.org/T269608> it’s no mystery why the error only started happening now in CI – there was an integration/config change <https://gerrit.wikimedia.org/r/658449> yesterday which added EventBus as a dependency of EventLogging (tagged with T272863 <https://phabricator.wikimedia.org/T272863>), and I’d guess that this transitively pulled EventBus into the Wikibase tests, causing the error. I’m not sure how to properly fix this error. I’m guessing that pulling EventBus out of the CI config again isn’t the best solution (but CC @Mholloway, @Ottomata), but I don’t know enough about it to say whether that call to `createMultiClient()` can / should be avoided. For now we can skip the failing Wikibase test, but that’s not a complete solution. TASK DETAIL https://phabricator.wikimedia.org/T272998 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Ottomata, Mholloway, Addshore, Silvan_WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
