daniel added a comment.
@Lucas_Werkmeister_WMDE wrote: > so for a RevisionRecord belonging to a non-local wiki, calling getId() without arguments will now trigger a call to wfDeprecatedMsg(). But wfDeprecatedMsg() is apparently enough to make unit tests fail, and also cause warnings to be displayed in the page output, so I assume it counts as hard deprecation. Shouldn’t there have been a period of soft deprecation in between? Soft deprecation is for the period between deciding that some code or behavior should be removed, and removing all known callers. I didn't spot the callers in Wikibase code, though I suspected they exist. We decided to add the deprecation warning to find any remaining callers. I told Adam to look out for that during our lunch meeting last week. I'm sorry for causing you work. Unfortunately, there didn't seem to be a good way to flush these issues out beforehand - afterall, Wikibase CI tests passed. Note that as far as I know, Wikibase the the only extension that currently uses cross-wiki support on RevisionStore. So this is hopefully the only thing broken by this change. TASK DETAIL https://phabricator.wikimedia.org/T273622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, daniel Cc: hashar, WMDE-leszek, RhinosF1, Peter.ovchyn, Vlad.shapik, Lucas_Werkmeister_WMDE, Pchelolo, daniel, Addshore, toan, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, WDoranWMF, Kent7301, alaa_wmde, holger.knust, EvanProdromou, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
