bete added a comment.
In T273039#6799706 <https://phabricator.wikimedia.org/T273039#6799706>, @ItamarWMDE wrote: >> We could, in the future, extend that to support routing libraries like vue-router. > > This argument is enough to win me over. Usually I'm not in favor of creating components simply for styling purposes, and since we already expose a global CSS file that is used by consuming applications <https://github.com/wmde/query-builder/blob/master/src/App.vue#L59>, I don't necessarily see it as a problem to scope styles as a reusable CSS class that is available to implementing applications. However, once you add state and behavioral considerations into the mix, it makes a little more sense to me. > > Either or, I will back your decision even if there were no such considerations, as the research seems well thought of and there are other compelling arguments. > > I would ask though, how do you envision the API of this component to work? Is it something like `<Link type="external">...</Link>`? yes, that was my idea for the API TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
