Lucas_Werkmeister_WMDE added a comment.
> - Do we always want to convert spaces to %20 in external IDs? > - Yes, unless "other website" needs us to code it differently I wrote a Python script to query a random sample of each external identifier property and count how many of the identifiers had spaces (P14273 <https://phabricator.wikimedia.org/P14273>). It turns out the number of properties with spaces is somewhat larger than I expected (full output at P14274 <https://phabricator.wikimedia.org/P14274>), so I only manually checked those properties with a 100% ratio of identifiers containing spaces: P9094: no formatter URL P8832: + ✔, %20 ✔, _ ✘ P8514: weird website behavior P7549: + ✔, %20 ✔, _ ✘ P6700: no formatter URL P6164: no formatter URL P5738: + ✘, %20 ✔, _ ✘ P5667: + ✔, %20 ✔, _ ✘ P5609: + ✔, %20 ✔, _ ✘ P5049: no formatter URL P4814: + ✔, %20 ✔, _ ✔ P4483: + ✔, %20 ✔, _ ✘ P4245: no formatter URL P3248: formatter URL deprecated P2878: no formatter URL P2590: no formatter URL P2589: no formatter URL P1261: no formatter URL P1161: no formatter URL P213: + ✔, %20 ✔, _ ✔ In conclusion: **`%20` works everywhere**, `+` works almost everywhere but not universally, `_` is uncommon. So I think it’s probably safe to go ahead with just `%20` and not make this configurable, unless anyone finds a concrete example of a website that requires `+`. TASK DETAIL https://phabricator.wikimedia.org/T271126 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Addshore, Aklapper, Lydia_Pintscher, Mohammed_Sadat_WMDE, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
