Charlie_WMDE added a comment.
Improvement C: i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop <https://www.figma.com/file/hZpaYX0xNNhK0L7kBvN6WK/Query-Builder?node-id=3168%3A2789> and they're all using the same token. let me know if this should be an extra ticket or can be done in this one Improvement E: - The buttons switch to full width a bit later than layout 4 is triggered Not sure if related but: - the run query button is now always size L, even in layout 1-3 (should only be the case for layout 4) Improvement F: - most of the spacing is not correct unfortunately. Except for the spacing between the "run query button" and the "link to query", and the spacing between the "settings header" and the "decorator" they're all off by a few pixels. happy to have a chat about the details if you like! TASK DETAIL https://phabricator.wikimedia.org/T274283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Charlie_WMDE Cc: Aklapper, Charlie_WMDE, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
