Ladsgroup moved this task from Ready for story time to Peer Review on the Wikidata Query Builder board. Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup.
This took hours and a headache to let me understand what's happening. The fix is: https://github.com/wmde/query-builder/pull/209 So, it doesn't happen if you copy-paste the url but it does happen if you refresh the page with ctrl+r, at first I thought it might be something in the headers and referrer was a candidate. It was the only thing different in headers when you make a request by copy-pasting the URL but it doesn't happen if you right-click on it and open on the new tab and it does have the referrer too so that's not the issue. Comparing how we make the iframe with scholia (and reading about iframes in general). I learned that we sandbox our iframe which does some security measure. The problem is that sandbox <https://www.w3schools.com/tags/att_iframe_sandbox.asp> is extremely restrictive (which is a good thing in general) and you need to turn on each feature one by one. The reason this happens is that when you click on it meaning you allow a popups, it carries the sandbox mode to the new tab and it breaks wdqs gui (I couldn't figure out exactly how, the number of caught exceptions in gui is really astonishing) but when turning on `allow-popups-to-escape-sandbox` would fix it. I assume when don't let bad js being ran in the iframe nor we link to problematic websites there. So this is fine. TASK DETAIL https://phabricator.wikimedia.org/T273184 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
