matthiasmullie added a comment.

  I suspect the correct solution within `MediaInfoHandler::getTitleForId` would 
probable be to throw an `InvalidArgumentException` in case there's no title for 
the given id (`EntityHandler::getTitleForId` is documented to throw that 
exception `if $id refers to an entity of the wrong type.`)
  
  That, and whatever code path (`EntityDataUriManager::getDocTitle`?) currently 
ends up calling it with such invalid entity id should probably be be updated to 
catch that exception (or not allow triggering it in the first place) and handle 
it more gracefully (unless that exception is already being caught, but the 
`TypeError` prevents it from getting there)

TASK DETAIL
  https://phabricator.wikimedia.org/T273506

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matthiasmullie
Cc: matthiasmullie, Umherirrender, MarkTraceur, CBogen, Cparle, WMDE-leszek, 
Addshore, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Aklapper, GFontenelle_WMF, 
FRomeo_WMF, Muchiri124, ItamarWMDE, Nintendofan885, Akuckartz, darthmon_wmde, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, 
GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, 
Ixocactus, Wong128hk, Verdy_p, abian, Jane023, Wikidata-bugs, Base, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Steinsplitter, Mbch331, Rxy, Jay8g, Keegan
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to