Addshore added a comment.
I'v gone ahead and hit +2 on a patch that will fix the issue and a test to go along with it. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/662735 & https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/666530 Trying to extract some things from a little discussion we had on mattermost yesterday relevant to the decisions around the approach > Leszek: and any word on having this thing in wikibase wikibase and not wikibase media info? > Adam: well, this applies to MCR, not specifically to mediainfo IMO, so wikibase is probably the right place > Adam: Wikibase is what deals with the MCR support > Leszek: noted, thanks for elaboration (sorry for the late reply - unreliable life schedule) > Lucas: hm, so I’m the only one left who’s not happy with that change (my own)? > Leszek: I am not over the moon about it but for different reasons that you mentioned > Adam: which comments in the CR relate to the open concerns? > Lucas: not sure if I left that in a CR comment at some point, but I’m unhappy with that change because it reconstructs the information “does the revision match the entity ID” almost from scratch, when at an earlier point in the EntityRevisionLookup we already have most of that logic; that’s the motivation for Icd91dc1cb5 > Adam: right, so looking at that change my gut would be to stick with this other one as it is done, easy to follow and we are talking about a low traffic occurrence anyway. > Most if not all of the things loaded in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/662735/6/repo/includes/Api/EntityLoadingHelper.php#288 should be cached in some way (revision lookup) > Lucas: okay > Adam: stares at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/664583 a bit more TASK DETAIL https://phabricator.wikimedia.org/T267363 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: WMDE-leszek, Tarrow, Lucas_Werkmeister_WMDE, Addshore, Aklapper, FRomeo_WMF, Alter-paule, Beast1978, CBogen, Un1tY, Nintendofan885, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Jonas, abian, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
