thiemowmde added a comment.

Is this about `use` keywords or `@uses` tags in tests? The first doesn't need 
discussion, in my opinion. The second does.

I'm preferring `new \TestUser()` (to give an example) over `use TestUser;` in 
very, very few cases. For a single reason: PHPStorm removes some `use` lines 
when pressing Ctrl+Alt+O. But I don't mind (any more) if we are changing all of 
these to use `use`.

In general there should not be any `\` in the code. I do have the impression 
that we all agree on that. Therefor I don't think this is an issue that needs 
to be tracked in Phabricator. I suggest to close this.


TASK DETAIL
  https://phabricator.wikimedia.org/T45295

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: adrianheine, thiemowmde, Wikidata-bugs, jayvdb, JeroenDeDauw, aude, 
Lydia_Pintscher



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to