Addshore added a comment.
Any further changes to avoid skipped Qids would likely need some larger changes to some core Wikibase code or how ids are generated. Skipping probably started happening more once we fixed T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId <https://phabricator.wikimedia.org/T194299> We did have another idea for solving that issue back then in T194299#4712763 <https://phabricator.wikimedia.org/T194299#4712763> In T194299#4712763 <https://phabricator.wikimedia.org/T194299#4712763>, @Addshore wrote: > One idea that @daniel and I had for this was simply to spread the ItemId counter out over 2 or more rows.. having one row deal with an odd counter and another deal with an even counter. > This would mean that ids would no longer be guaranteed to be created in order, and the counters might drift (but we could put something in place to fix that?), but the issue of too much stuff trying to work on a single row would be solved. This would mean we could move back to fetching Ids in the same transaction as the main writes (so the id claim would also be rolled back on failure). But as long as we are okay having some skipped IDs I would propose not touching it more now, they are after all, only numbers! TASK DETAIL https://phabricator.wikimedia.org/T44362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Lucas_Werkmeister_WMDE, Addshore, MisterSynergy, Lea_Lacroix_WMDE, Bugreporter, StudiesWorld, ChongDae, Wikidata-bugs, jeblad, Legoktm, Nemo_bis, Merl, Lydia_Pintscher, jeremyb, Stryn, daniel, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, abian, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
