Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Several places in Wikibase call `WikibaseSettings::getRepoSettings()` or `WikibaseSettings::getClientSettings()` directly, instead of getting the settings from elsewhere. This is wasteful, because `WikibaseSettings` doesn’t cache the settings – each time it’s called, the work of loading the settings and merging them with the default settings is repeated. (Also, settings that are specified as callbacks may be recalculated, even if another settings instance already resolved the callback.) Most of these calls should be replaced with calls to `WikibaseRepo::getSettings()` or `WikibaseClient::getSettings()`, optionally passing a `$services` container into them if available. TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
