Legoktm added a comment.
In T277362#6916991 <https://phabricator.wikimedia.org/T277362#6916991>, @Lucas_Werkmeister_WMDE wrote: > I also notice that MediaWiki core has again hard-deprecated code that is still used in Wikimedia-maintained code even though the stable interface policy forbids this: > >> Hard deprecation MUST NOT be applied to code still used in Wikimedia maintained code. Such usage MUST be removed first. > > Last time this happened, the explanation (T273622#6797449 <https://phabricator.wikimedia.org/T273622#6797449>) was that it was not possible to catch these usages without hard deprecation. Maybe this is a similar case, but is it too much to ask that such deprecations are at least called out or explained somewhere, e.g. in the Gerrit change introducing them or in the related Phabricator task? How are developers supposed to flag up these occurrences if the deprecation message doesn’t even mention the related task? That's not a valid reason to bypass the deprecation policy. In the past we just added logging for it (e.g. T176526: Remove $wgTitle fallback from EditPage in MW1.36 <https://phabricator.wikimedia.org/T176526>) until we were satisfied we had caught everything. I would propose reverting the core change on the basis that it did not follow the deprecation policy, and then move the train forward again. Holding it because someone else broke the policy doesn't make sense to me. TASK DETAIL https://phabricator.wikimedia.org/T277362 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm Cc: Legoktm, RhinosF1, brennen, Lucas_Werkmeister_WMDE, Ladsgroup, Addshore, hoo, daniel, WMDE-leszek, toan, Aklapper, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, AMooney
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
