thiemowmde added a comment. I just wrote this as an email to wikimedia-de-tech. As a reference:
GitHub does have two major problems: 1. It's not possible to add people for review. There is no review board. You can ping people via email, which usually gets lost. You can assign one person, which never turned out to be useful whenever I tried that. I don't even know what that actually does. Just sending another email? 2. It's not possible to chain patches. It's not possible to continue working on code until it is merged. This creates the situation where you have to: - stop working on certain code until the base patch is merged, - force team members to merge base patches fast, - create chains of multiple commits in one pull request, which usually makes such pull requests non-reviewable (as happened in the "remove Claim" task, for example), - create duplicates that touch the same lines of code, which causes merge conflicts and means reviewers must review the same code multiple times. All these possibilities are wasting somebodys time. GitHub is a nice tool, but it just doesn't fit our workflows. TASK DETAIL https://phabricator.wikimedia.org/T74907 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, Glaisher, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
