daniel added a comment.
NameTableStore can become newable. The fact that it 's not is just an oversight from my point of view. I'd be reluctant to make it // stable to extend//, though. NameTableStoreFactory is conceptually questionable - different NameTableStore instances may be used for totally different things, so NameTableStoreFactory is bound to cross domain boundaries. The way it's currently used it's really bound to the revision storage backend. Perhaps the could be a base class or a trait or a helper that would make it easy to implement separate factories for different use cases of NameTableStore. TASK DETAIL https://phabricator.wikimedia.org/T276551 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: daniel, BPirkle, Addshore, Aklapper, Lucas_Werkmeister_WMDE, maantietaja, Akuckartz, WDoranWMF, holger.knust, EvanProdromou, Nandana, Banyek, Rayssa-, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, abian, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
