Lucas_Werkmeister_WMDE added a comment.
And as for TermSearchInteractorFactory, it’s worth noting that
`WikibaseClient` has a method
/**
* XXX: This is not used by client itself, but is used by
ArticlePlaceholder!
*/
public function newTermSearchInteractor( string $displayLanguageCode ):
TermSearchInteractor {
return
self::getWikibaseServices()->getTermSearchInteractorFactory()
->newInteractor( $displayLanguageCode );
}
but ArticlePlaceholder hasn’t actually used this method since March 2020
(removed in rEARP3c9ae982ece3: Drop legacy database search integration code
<https://phabricator.wikimedia.org/rEARP3c9ae982ece33c239c4fd158922360db9ef06d6e>).
So as far as I can tell, we can remove the WikibaseClient use of that service
directly.
TASK DETAIL
https://phabricator.wikimedia.org/T277856
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot,
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
