Lucas_Werkmeister_WMDE added a comment.
Well…
- `getItemLookup()` is called:
- twice with `LOOKUP_CACHING_RETRIEVE_ONLY`
- //never// with `LOOKUP_CACHING_ENABLED` (the default)
- `getPropertyLookup()` is called:
- twice with `LOOKUP_CACHING_RETRIEVE_ONLY`
- once with `LOOKUP_CACHING_DISABLED`
- once with `LOOKUP_CACHING_ENABLED` (the default)
So it seems kind of pointless to move a default version of the `ItemLookup`
service to the service container when that default version is never used – and
really, both of those services are barely used at all.
And seeing as they’re both very simple wrappers around `EntityLookup` (using
the `LegacyAdapterItemLookup` and `LegacyAdapterPropertyLookup` classes,
respectively), maybe the easiest way forward is to just inline those methods
into their few callers, and have those callers create those wrappers directly?
(We could also maybe reconsider if we really need those `ItemLookup` and
`EntityLookup` interfaces separate from `EntityLookup`, but that’s a topic for
another day, I think.)
TASK DETAIL
https://phabricator.wikimedia.org/T279527
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
