thiemowmde created this task. thiemowmde added subscribers: thiemowmde, JeroenDeDauw. thiemowmde added projects: Wikidata, Patch-For-Review. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION @JeroenDeDauw wrote: > [...] I just looked into why I got a dozen or so failure emails for Wikibase from TravisCI. Apparently we recently broke the build with 2 test failures. For some reason those did not occur on Jenkins. I tried locally and got the failures as well. The failures on TravisCI ought to be fixed by https://gerrit.wikimedia.org/r/#/c/196151/ (verified locally) [...] Personally, I can not reproduce the failing test locally. I was able to nail the problem down to a "magic" `==` comparison of two `Diff` objects in `ClaimDifference::equals`. My PHP 5.3.10 thinks that `new Diff( array( new DiffOpAdd( 1 ) ) )` and `new Diff( array( new DiffOpAdd( 2 ) ) )` are equal. I did not dug deeper into why this happens. Relevant patches: * TBA * https://github.com/wmde/Diff/pull/41 * https://gerrit.wikimedia.org/r/#/c/196151/ TASK DETAIL https://phabricator.wikimedia.org/T92487 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: JeroenDeDauw, thiemowmde, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
