Lucas_Werkmeister_WMDE added a comment.

  > I suggest inlining `getFieldDefinitionsByType()`.
  
  On second thought, since this is used for several entity types both in 
Wikibase and in other extensions, it’s probably worth it to extract a service 
for this.

TASK DETAIL
  https://phabricator.wikimedia.org/T279939

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to