thiemowmde added a comment. I consider code being scattered around an issue. Trying to work with these components gets messy fast, see https://phabricator.wikimedia.org/T92268.
Having all DataValues in one repository introduces only one issue, as far as I can see, and that doesn't even really qualify as an "issue": If a user doesn't care about, for example, QuantityValue, he will have some unused files in his repository. But how is that an issue? On the other hand: It's not possible to use NumberValue without QuantityValue because they are in the same repository anyway. It's not possible to //not// use BooleanValue because it's in one of the base components. And there are 3 or 4 of these base components, I lost track. Time related stuff is still scattered around a lot, mostly in Wikibase\Lib. There is a component called "common", but it only contains Mono- and MultilingualTextValues. "common" also contains parsers, e.g. a BoolParser, while the BooleanValue is in a component called "data-values". That "data-values" component also contains some interfaces, while there is a separate component called "interfaces". StringValue is in "data-values", StringFormatter and StringValueParser in "common" and a StringValidator in an other component called "validators". What's "validators"? What's "common"? What's the difference between "common" and "data-values"? Is "data-values" not common? What's the difference between "common" interfaces and "interfaces" interfaces? TL;DR: It's a mess and needs cleanup anyway. TASK DETAIL https://phabricator.wikimedia.org/T92279 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: JeroenDeDauw, Snaterlicious, Qgil, thiemowmde, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
