Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, wdwb-tech (wdwb-tech (small tasks)). Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION I just came across the `SiteLinkTable::clear()` method, which truncates the whole `wb_items_per_site` table (as a `delete()` with conditions `'*'`). If this method is ever called in production, I assume it will immediately cause replication lag to skyrocket as the replicas struggle to delete millions and millions of rows – not to mention the functionality impact of suddenly losing all connections between pages and items (compare T249565 <https://phabricator.wikimedia.org/T249565>), or that the table would take at least several hours to rebuild (compare T249596 <https://phabricator.wikimedia.org/T249596>, and that was after a backup of the table had been restored). In other words, this looks like a footgun, an accident waiting to happen. Fortunately, `SiteLinkStore::clear()` (the parent interface method) is apparently only called from one place in the code, `SqlStore::clear()`; and `Store::clear()` (ditto) is never called anywhere at all. I suggest we unceremoniously remove both of these methods and their implementations. TASK DETAIL https://phabricator.wikimedia.org/T281171 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
