thiemowmde added a comment.
I'm not working with these codebases any more. But since I created this ticket once, I had a quick look at some random codebases I could find. These execute phpcs as part of `composer test`: - https://github.com/wmde/Number/blob/master/composer.json#L56 - https://github.com/wmde/Time/blob/master/composer.json#L54 - https://github.com/DataValues/Validators/blob/master/composer.json#L50 - … These **don't**: - https://github.com/wmde/WikibaseDataModel/blob/master/composer.json#L59 - https://github.com/wmde/WikibaseDataModelSerialization/blob/master/composer.json#L62 - https://github.com/wmde/WikibaseDataModelServices/blob/master/composer.json#L49 - https://github.com/wmde/WikibaseInternalSerialization/blob/master/composer.json#L55 - … - There are also quite some `data-values/*` components that aren't forked to the `wmde` organization yet, and also do not execute phpcs as part of `composer test`. Whatever you decide (and I believe the team currently working with these codebases should be free to decide whatever they find most helpful), my personal recommendation is to make sure all codebases do the same on `composer test`. As of now there isn't much consistency, not even for the few codebases still in the DataValues org <https://github.com/search?q=org%3ADataValues+%22phpcs+-p%22&type=code>. Note: When you change `composer test` to include phpcs, please make sure the existing `ci` command does not execute phpcs twice <https://github.com/wmde/WikibaseInternalSerialization/pull/136/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L64>. TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete, thiemowmde Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
