Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION The `WikibaseClient.PropertyLabelResolver` service wiring uses the `ObjectCache::getInstance()` function with a variable `$cacheType`. If no such instance is set yet, then `ObjectCache` will try to access MediaWiki globals and the default service container to create the instance, so that the unit test for that service wiring actually can’t run without MediaWiki being set up. This is similar but not the same thing as T281708 <https://phabricator.wikimedia.org/T281708> and T281706 <https://phabricator.wikimedia.org/T281706>, and won’t be solved by T243233 <https://phabricator.wikimedia.org/T243233>. Given that `ObejctCache::$instances` is public, maybe we can just set a mock cache in the test case setup, so that `getInstance()` will return it without trying to create an instance? The alternative would be some kind of `ObjectCacheFactory` service, I guess. TASK DETAIL https://phabricator.wikimedia.org/T281709 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
