hoo created this task.
hoo added projects: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
`ImageLinksDataUpdater::updateParserOutput` confuses the file's SHA1 and
timestamp when calling `ParserOutput::addImage`. Given this data seems to not
get used (outside of the `FlaggedRevs` extension, which is incompatible to
Wikibase), the impact of this should be negligible.
From `ImageLinksDataUpdater::updateParserOutput`:
$parserOutput->addImage(
$fileName,
$file ? $file->getSha1() : false,
$file ? $file->getTimestamp() : false
);
While the actual signature for that method is:
/**
* Register a file dependency for this output
* @param string $name Title dbKey
* @param string|false|null $timestamp MW timestamp of file creation
(or false if non-existing)
* @param string|false|null $sha1 Base 36 SHA-1 of file (or false if
non-existing)
*/
public function addImage( $name, $timestamp = null, $sha1 = null );
TASK DETAIL
https://phabricator.wikimedia.org/T282440
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: hoo
Cc: Aklapper, hoo, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
