Jakob_WMDE added a comment.

  Leaving some thoughts here since I looked into this quite a bit before but am 
not going to work on it myself. I believe the patch I uploaded is ready to go 
aside from needing the properly released WikidataApiGem. It already passed the 
the buster mwselenium job (here 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/680996/13#message-a7177f9a6b495219b80e97ccc63ecf6965e3f63e>)
 and only failed on the rake job because the two were using very different Ruby 
versions. If both jobs are flipped to the newer images it should just work 
(tm). These are the remaining steps that (I think) are missing here:
  
  1. Release and publish a new version of 
https://github.com/wmde/WikidataApiGem - the necessary changes 
<https://github.com/wmde/WikidataApiGem/pull/12> are already in the master 
branch.
  2. Use the newly released package in 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/680996 instead 
of the github branch here: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/680996/13/tests/browser/Gemfile#7
  3. Verify //somehow// that this works. I believe the patch should pass on 
It's going to fail on the regular ruby jobs because of some version 
incompatibilities, so maybe we can add experimental jobs running the buster 
versions of `rake-docker` and `mwselenium-quibble-docker`?
  4. Once it's verified, poke @Jdforrester-WMF to do the switch? Also backport 
it to the relevant release branches (see this comment 
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/680996/13#message-93500f36c897217e8e2552a3c8973280df9b6cd4>)?

TASK DETAIL
  https://phabricator.wikimedia.org/T280491

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Jdforrester-WMF, Aklapper, Jakob_WMDE, WMDE-leszek, Addshore, Ladsgroup, 
ItamarWMDE, Invadibot, Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to