thiemowmde created this task. thiemowmde added a subscriber: thiemowmde. thiemowmde added projects: Wikidata, DataValues. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Time precision constants are currently named in PHP: * PRECISION_Ga * PRECISION_100Ma * PRECISION_10Ma * PRECISION_Ma * PRECISION_100ka * PRECISION_10ka * PRECISION_ka * PRECISION_100a * PRECISION_10a * PRECISION_YEAR * PRECISION_MONTH * PRECISION_DAY * PRECISION_HOUR * PRECISION_MINUTE * PRECISION_SECOND And in JavaScript: * GY * MY100 * MY10 * MY * KY100 * KY10 * KY * YEAR100 * YEAR10 * YEAR * MONTH * DAY * HOUR * MINUTES * SECOND There are several problems: The names are different. They contain lower case characters. They are confusing. My suggestion: * PRECISION_YEAR1G * PRECISION_YEAR100M * PRECISION_YEAR10M * PRECISION_YEAR1M * PRECISION_YEAR100K * PRECISION_YEAR10K * PRECISION_YEAR1K * PRECISION_YEAR100 * PRECISION_YEAR10 * PRECISION_YEAR * PRECISION_MONTH * PRECISION_DAY * PRECISION_HOUR * PRECISION_MINUTES * PRECISION_SECOND Relevant patches: * https://github.com/DataValues/Time/pull/42 * https://github.com/wmde/DataValuesJavascript/pull/68 * https://gerrit.wikimedia.org/r/#/c/194306/ TASK DETAIL https://phabricator.wikimedia.org/T92954 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Wikidata-bugs, aude _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
