Jc3s5h added a comment.

In https://phabricator.wikimedia.org/T85296#973355, @Addshore wrote:

> Okay, so when entering "31 September 1949" through the Frontend in an edit 
> and saved it is formatted as "1 October 1949" and correctly saved as 
> "+00000000019-10-01T00:00:00Z"
>  This suggests that the date in question has been added through the API and 
> extra validation is needed there...
>
> However looking further at the Item I see this edit 
> https://www.wikidata.org/w/index.php?title=Q5906&diff=118880783&oldid=118880605
>  in which the 31 September is added. Presuming the Front-end was either fixed 
> after this edit (Which was in April) I think it is time to check the API 
> validation!


I find it alarming that 31 September was corrected to 1 October. It is alarming 
because has not been made clear in this thread what code is making the 
correction, and what rules are being followed. It may be safe enough to correct 
31 September to 1 October, but what if the user enters 30 February 1900? Should 
that be corrected to 2 March 1900 or 1 March 1900? It depends on whether the 
calendar model is Julian or Gregorian. Is the code making the correction taking 
the calendar model into account? If the code is not cognizant of the Julian 
calendar, will it prevent the correct entry of 29 February 1900 Julian?


TASK DETAIL
  https://phabricator.wikimedia.org/T85296

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jc3s5h
Cc: Jc3s5h, Liuxinyu970226, Ricordisamoa, Addshore, thiemowmde, JanZerebecki, 
Aklapper, daniel, Smalyshev, Wikidata-bugs, aude



_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to