Lucas_Werkmeister_WMDE added a comment.
In T247300#5958470 <https://phabricator.wikimedia.org/T247300#5958470>, @hoo wrote: > If not terribly many pages are affected by this, `page_props` are the way to go (or, if almost all unlinked pages will have it, in a negated form, that indicates the page is unconnected, but shouldn't be). I would assume most unlinked pages would eventually have the magic word – the expected state is probably that almost all pages have either a linked item or the magic word, and items that have neither are the remaining ones that need to be cleaned up. So from that perspective, it would probably be more efficient to add a page prop when the magic word //isn’t// present. However, that would also make the migration more difficult. If we add the page prop when the magic word is present, then we can deploy the code change that introduces the magic word, without any changes to the `page_props` table. If we want to add the page prop when the magic word //isn’t// present, then during the initial rollout we would need to add the page prop to all unlinked pages. (Or have an intermediate stage where we always write the page prop, with value `0` or `1` depending on whether the magic word is there or not, and then once all unconnected pages have the page prop, we can change the default interpretation and stop writing one of the two values…) I feel like optimizing the page prop is probably not worth the effort (after all, connected pages almost certainly outnumber unconnected pages, whether expected or unexpected, as long as we don’t count excluded namespaces, and we write a page prop for each connected page), and we should just write a page prop whenever we encounter the magic word. (If that becomes a problem, we can still change it later.) TASK DETAIL https://phabricator.wikimedia.org/T247300 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Manuel, Aklapper, Lydia_Pintscher, hoo, daniel, Ladsgroup, WMDE-leszek, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
